Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where job is nil in Que error notifier #548

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

tobyhs
Copy link
Contributor

@tobyhs tobyhs commented Jun 17, 2019

Goal

To handle cases where the job block parameter is nil. According to https://github.com/chanks/que/blob/master/docs/error_handling.md#error-notifications this occurs on database connection failures and similar errors.

Changeset

Added

nil/false check in lib/bugsnag/integrations/que.rb

Linked issues

Fixes #545

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@tobyhs tobyhs requested a review from snmaynard June 17, 2019 18:17
@tobyhs tobyhs changed the base branch from master to next June 18, 2019 01:10
@tobyhs tobyhs merged commit 90df996 into next Jun 18, 2019
@tobyhs tobyhs deleted the tobyhs/handle_nil_job_in_que branch June 18, 2019 01:29
@tobyhs tobyhs mentioned this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants